Skip to content

feat(route): add Anhui Museum news and exhibition route - #23112

Open
magazian wants to merge 2 commits into
DIYgod:masterfrom
magazian:feat-ahm
Open

feat(route): add Anhui Museum news and exhibition route#23112
magazian wants to merge 2 commits into
DIYgod:masterfrom
magazian:feat-ahm

Conversation

@magazian

@magazian magazian commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Involved Issue / 该 PR 相关 Issue

Close #

Example for the Proposed Route(s) / 路由地址示例

/ahm/exhibition/xztj
/ahm/news/abxw

New RSS Route Checklist / 新 RSS 路由检查表

  • New Route / 新的路由
  • Anti-bot or rate limit / 反爬/频率限制
    • If yes, do your code reflect this sign? / 如果有, 是否有对应的措施?
  • Date and time / 日期和时间
    • Parsed / 可以解析
    • Correct time zone / 时区正确
  • New package added / 添加了新的包
  • Puppeteer

Note / 说明

@github-actions github-actions Bot added the route label Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Auto Review

[Rule 13/24 — parseDate & time zone]

  • lib/routes/ahm/xztj.tsx: dates go through dayjs(dateStr).format(...) and then parseDate(startDate) with no time-zone correction, while lib/routes/ahm/abxw.ts correctly wraps with timezone(parseDate(...), 8). Source dates are Beijing time, so pubDate here is off by 8 hours. Fix: drop the dayjs round-trip and use pubDate: startDate ? timezone(parseDate(startDate), 8) : undefined;, adding an import of timezone from @/utils/timezone.

[Rule 11/22 — description content]

  • lib/routes/ahm/xztj.tsx: the rendered description repeats pubDate (the 开展： line is exactly the value set as pubDate) and repeats the start/end dates again via 原始展期：{fullDuration}. Fix: drop the 开展： block and the duplicated 原始展期 paragraph, keeping only content not already carried by dedicated fields (image, 地点, 闭展).

Resolved since the last review: the duplicate-guid fallback in xztj.tsx is now guarded by an early empty-array return.

@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Successfully generated as following:

http://localhost:1200/ahm/exhibition/xztj - Failed ❌ 
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>TimeoutError: page.waitForSelector: Timeout 15000ms exceeded.
Call log:
  - waiting for locator(&#39;ul.exhibition-new li&#39;) to be visible
Route: /ahm/exhibition/xztj
Full Route: /ahm/exhibition/xztj
Node Version: v24.19.0
Git Hash: eeac2f50
http://localhost:1200/ahm/news/abxw - Failed ❌ 
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>TimeoutError: page.waitForSelector: Timeout 15000ms exceeded.
Call log:
  - waiting for locator(&#39;ul.img-cont-list li&#39;) to be visible
Route: /ahm/news/abxw
Full Route: /ahm/news/abxw
Node Version: v24.19.0
Git Hash: eeac2f50

@github-actions github-actions Bot added the auto: not ready to review Users can't get the RSS feed output according to automated testing results label Aug 25, 2026
@magazian

magazian commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author
image image the route works locally.

@github-actions github-actions Bot added auto: not ready to review Users can't get the RSS feed output according to automated testing results and removed auto: not ready to review Users can't get the RSS feed output according to automated testing results labels Aug 25, 2026
@github-actions

github-actions Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Successfully generated as following:

http://localhost:1200/ahm/exhibition/xztj - Failed ❌ 
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>TimeoutError: page.waitForSelector: Timeout 15000ms exceeded.
Call log:
  - waiting for locator(&#39;ul.exhibition-new li&#39;) to be visible
Route: /ahm/exhibition/xztj
Full Route: /ahm/exhibition/xztj
Node Version: v24.19.0
Git Hash: b32afd48
http://localhost:1200/ahm/news/abxw - Failed ❌ 
HTTPError: Response code 503 (Service Unavailable)

Error Message:<br/>TimeoutError: page.waitForSelector: Timeout 15000ms exceeded.
Call log:
  - waiting for locator(&#39;ul.img-cont-list li&#39;) to be visible
Route: /ahm/news/abxw
Full Route: /ahm/news/abxw
Node Version: v24.19.0
Git Hash: b32afd48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

auto: not ready to review Users can't get the RSS feed output according to automated testing results route

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@magazian